Skip to content

Make Crashlytics context Init unblocking main #14754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Make Crashlytics context Init unblocking main #14754

merged 1 commit into from
May 1, 2025

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Apr 22, 2025 •
edited
Loading

Covert dispatch_group_wait to use promise to avoid blocking on main

Profiling and verified FIRCLSContextInit is gone from main call stack trace: https://screenshot.googleplex.com/8hPfVTxvxnh9X2b

Related issues: #13675 #13232

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@themiswang themiswang marked this pull request as ready for review April 22, 2025 23:01
@themiswang themiswang force-pushed the promiseChain branch 3 times, most recently from f588665 to 50b1e19 Compare April 24, 2025 11:54
@themiswang themiswang changed the title wip Make Crashlytics context Init unlocking main Apr 28, 2025
@themiswang themiswang requested a review from samedson April 28, 2025 16:58
samedson
samedson reviewed Apr 29, 2025
View reviewed changes
samedson
samedson approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

paulb777
paulb777 reviewed Apr 29, 2025
View reviewed changes
ncooke3
ncooke3 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@themiswang themiswang changed the title Make Crashlytics context Init unlocking main Make Crashlytics context Init unblocking main Apr 29, 2025
paulb777
paulb777 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@themiswang themiswang merged commit f5f8fa5 into main May 1, 2025
104 of 109 checks passed
@themiswang themiswang deleted the promiseChain branch May 1, 2025 15:48
This was referenced May 1, 2025
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@samedson samedson samedson approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: crashlytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@themiswang @paulb777 @samedson @ncooke3 @google-oss-bot